Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applying changes for new version of Cost Management APIs 2018-08-31 #3961

Closed
wants to merge 14 commits into from
Closed

Applying changes for new version of Cost Management APIs 2018-08-31 #3961

wants to merge 14 commits into from

Conversation

ms-premp
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • [Y ] The title of the PR is clear and informative.
  • [ Y] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • [ Y] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@ms-premp
Refactoring Pricesheet response spec to fix model names and references.
c7cb3f2
@ms-premp
Updating examples to correctly reflect the response model
47c6f79
@ms-premp
Fixing examples for updated pricesheet model response.
f79454d
@ms-premp
Providing nextLink name and removing x-ms-pageable for budget PUT ope…
0cd14d0 
…ration.
@ms-premp
Fixing nextLink definition in response schema.
f070fe9
@ms-premp
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
2cc691a
@ms-premp
Updating $filter parameter sample values in examples. Earlier version…
cbefdc6 
… had incorrect format for the date values.
@ms-premp
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
562c8d4
@ms-premp
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
eba9b0c
@ms-premp
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
a5411de
@ms-premp
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
46efa72
@ms-premp
Copy of previous version 2018-05-31
475b890
@ms-premp
Applying changes for new version of CostManagement APIs 2018-08-31
c44fe3b
@ms-premp
Adding Operations to previous api version 2018-05-31
31140b8
@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@ms-premp ms-premp closed this Sep 19, 2018
@ms-premp
Copy link
Contributor Author

Abandoning this request

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Sep 19, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2924

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Sep 19, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1670

@AutorestCI AutorestCI mentioned this pull request Sep 19, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2767

@ms-premp
Copy link
Contributor Author

I already have this fork and everything here is up to date with original. so reopening this PR.

@ms-premp ms-premp reopened this Sep 19, 2018
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

This was referenced Sep 19, 2018
Closed
Closed
Closed
@ms-premp ms-premp closed this Sep 20, 2018
@ms-premp
Copy link
Contributor Author

Closing it. bad commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hovsepm hovsepm Awaiting requested review from hovsepm

Assignees

@hovsepm hovsepm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ms-premp @AutorestCI @azuresdkci @hovsepm